Thanks for the responses everyone, this has been really helpful.
In no particular order...
I think for now, I'll keep it long, and wear it. If I get it hemmed, it won't get it worn until Sept (as I have some vacation) and it would be nice to get a couple of wears in this year. Then I can see how it comes through the wash, and re-evaluate next year. If I do hem, I think I'll go a bit shorter than I have pinned it here.
I'm not sure I really want to look "elegant" in it, I was hoping for a fun casual dress. But I don't mind looking "modern", thanks Viva.
The citron sneakers have been awesome, I'm so glad I got them. Pil, they were from 2016 I think, so not surprising you can't find them. Angie did a blog post about them, just as I was discovering this colour, so I jumped.
Thanks for the legs compliments... I have plenty of short skirts and dresses, so no worries about them being hidden
And the cardigan. I think I will take a deep breath and let it go. I really love it, it's a great colour, and texture... but it just does NOT work for me. I got it for dresses, but as several mentioned, it's not short enough. And it's a bad length on me for wearing with pants. I got it in spring of 2017, and have worn it once (but not for lack of trying). And in that one outfit pic... I think it looks awful. I cringe when I see that pic.